fix(bindings/go): release owned c strings via c api#7403
Merged
Conversation
dosubot
Bot
added
size:L
Member
Author
|
If you feel this would be better handled as two separate PRs, please let me know. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The Go binding was not releasing heap-allocated strings returned by the C API after converting them into Go strings.
This could lead to memory leaks in repeated metadata queries such as
Info()and during large list operations. In addition, the C binding did not provide a dedicated API for releasing owned strings, which made the ownership contract harder to follow for managed-language bindings built on top of the C API.What changes are included in this PR?
This PR introduces a dedicated C API to release owned strings returned by the C binding and updates the Go binding to use it when handling string results.
It also updates the related C binding documentation and tests to reflect the new ownership contract, and adds Go regression tests to cover the affected paths.
Are there any user-facing changes?
No breaking user-facing API changes.
The main visible change is that the C binding now provides a dedicated string release API for bindings that consume owned strings from the C layer.
AI Usage Statement
This PR was developed with the help of OpenAI Codex.