Skip to content

fix(chaos): fix cases when error ratio = 1#7412

Merged
Xuanwo merged 1 commit intoapache:mainfrom
dentiny:hjiang/fix-chaos-error-ration-1
Apr 20, 2026
Merged

fix(chaos): fix cases when error ratio = 1#7412
Xuanwo merged 1 commit intoapache:mainfrom
dentiny:hjiang/fix-chaos-error-ration-1

Conversation

@dentiny
Copy link
Copy Markdown
Contributor

@dentiny dentiny commented Apr 19, 2026

Rationale for this change

With the current implementation, point could be 100 which returns true even if error ration assigned 1 (always failure).

What changes are included in this PR?

Random range should include 100 possible values instead of 101.

Are there any user-facing changes?

No

AI Usage Statement

Opus 4.6 found the bug when it was generating failure tests.

@dentiny dentiny requested a review from Xuanwo as a code owner April 19, 2026 09:51
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. releases-note/fix The PR fixes a bug or has a title that begins with "fix" labels Apr 19, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 20, 2026
@Xuanwo Xuanwo merged commit dab8ef2 into apache:main Apr 20, 2026
359 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/fix The PR fixes a bug or has a title that begins with "fix" size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants