feat(retry): introduce retry budget in retry layer#7430
Open
dentiny wants to merge 3 commits intoapache:mainfrom
Open
feat(retry): introduce retry budget in retry layer#7430dentiny wants to merge 3 commits intoapache:mainfrom
dentiny wants to merge 3 commits intoapache:mainfrom
Conversation
Contributor
Author
make_bucket: test
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 141 100 141 0 0 934 0 --:--:-- --:--:-- --:--:-- 940
./mc: line 1: a: No such file or directoryCI failure doesn't seem to be related |
Contributor
Author
---- behavior::test_list_empty_dir ----
test panicked: assertion `left == right` failed: only return the dir itself
left: 0
right: 1hmm not seem to relate to my changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7376
Rationale for this change
Current retry layer's implementation supports min/max retry duration, max count and jitter; when used together with timeout layer, we could also cap the upper bound for operation duration.
But in production, we've also observed retry storm, which degrades already overloaded / bad service.
Some implementation reference in the industry:
What changes are included in this PR?
This PR adds a no-op retry budget to retry layer:
Are there any user-facing changes?
Yes
AI Usage Statement
Opus 4.7 made most of the code change, I did the code review