feat(services/s3): Rename allow_anonymous to skip_signature#7544
Merged
Conversation
YuangGao
requested review from
Xuanwo,
Zheaoli,
messense and
tisonkun
as code owners
dosubot
Bot
added
size:L
Xuanwo
requested changes
May 18, 2026
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
This is a breaking change. Please deprecate the old options and add new ones instead of simply removing them.
YuangGao
force-pushed
the
feat/s3-skip-signature
branch
from
b018873 to
56daf14
Compare
dosubot
Bot
added
size:M
Contributor
Author
|
updated to keep |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Refs #7537.
Rationale for this change
allow_anonymouson S3 services is misleading — the implementation unconditionally skips credential loading and request signing rather than falling back from a failed credential load. Rename it toskip_signatureto describe the actual behavior, aligning withobject_store::AmazonS3Builder::with_skip_signature.What changes are included in this PR?
S3Config::allow_anonymoustoskip_signature, with#[serde(alias = "allow_anonymous")]so the old config key still deserializes.S3Builder::skip_signature(); keepS3Builder::allow_anonymous()as a#[deprecated]wrapper.S3Coreand updatesign_query/send/fetch.object_store_opendalintegration to mapSkipSignaturetos3.skip_signature().AllowAnonymous→SkipSignature).Are there any user-facing changes?
Yes, but not breaking
AI Usage Statement
AI-assisted implementation.