Skip to content

feat(services/gcs): Rename allow_anonymous to skip_signature#7567

Merged
Xuanwo merged 2 commits into
apache:mainfrom
YuangGao:feat/gcs-skip-signature
May 20, 2026
Merged

feat(services/gcs): Rename allow_anonymous to skip_signature#7567
Xuanwo merged 2 commits into
apache:mainfrom
YuangGao:feat/gcs-skip-signature

Conversation

@YuangGao
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

This PR renames the option to skip_signature and changes the semantics to unconditional skip

What changes are included in this PR?

  • Add GcsBuilder::skip_signature and GcsConfig::skip_signature.
  • Deprecate GcsBuilder::allow_anonymous and GcsConfig::allow_anonymous; both keep working and are merged into skip_signature at build time.
  • Change signing semantics from fallback-on-error to eager skip, matching other services.
  • Update .NET / Java / Python bindings accordingly

Are there any user-facing changes?

Behavior change for users who relied on the fallback semantics: if you previously set allow_anonymous(true) and provided valid credentials, GCS would sign requests. Now skip_signature(true) (and the deprecated
allow_anonymous(true)) unconditionally skips signing. Users who want signing should not set this option.

No source-breaking changes. allow_anonymous still compiles with a deprecation warning suggesting skip_signature.

@YuangGao YuangGao marked this pull request as ready for review May 20, 2026 03:39
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. releases-note/feat The PR implements a new feature or has a title that begins with "feat" labels May 20, 2026
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 20, 2026
@Xuanwo Xuanwo merged commit a21e9b8 into apache:main May 20, 2026
377 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/feat The PR implements a new feature or has a title that begins with "feat" size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants