Skip to content

refactor(services/sftp): deprecate copy option#7568

Merged
Xuanwo merged 2 commits into
mainfrom
xuanwo/sftp-capability-cleanup
May 20, 2026
Merged

refactor(services/sftp): deprecate copy option#7568
Xuanwo merged 2 commits into
mainfrom
xuanwo/sftp-capability-cleanup

Conversation

@Xuanwo
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo commented May 20, 2026

Which issue does this PR close?

Part of #6708.

Rationale for this change

SFTP enable_copy only controls the advertised copy capability. The SFTP copy implementation does not read this config flag; it streams data through the SFTP client and works with the existing test fixture.

What changes are included in this PR?

This PR enables SFTP copy capability by default, keeps enable_copy as a deprecated no-op compatibility option, and updates generated binding config docs.

Are there any user-facing changes?

No breaking changes. SFTP copy is now advertised by default; endpoints that need to disable copy in tests can use CapabilityOverrideLayer or OPENDAL_TEST_CAPABILITY_OVERRIDES=copy=false.

AI Usage Statement

N/A.

@Xuanwo Xuanwo requested a review from tisonkun as a code owner May 20, 2026 09:31
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" labels May 20, 2026
@Xuanwo Xuanwo requested review from Zheaoli and messense as code owners May 20, 2026 09:33
@dosubot dosubot Bot added lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels May 20, 2026
@Xuanwo Xuanwo merged commit 441bf63 into main May 20, 2026
459 checks passed
@Xuanwo Xuanwo deleted the xuanwo/sftp-capability-cleanup branch May 20, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants