feat: add reqwest-rustls-no-provider-tls feature#7582
Merged
Conversation
dosubot
Bot
added
size:XS
Member
Adds a new opt-in Cargo feature `reqwest-rustls-no-provider-tls` that maps to `reqwest/rustls-no-provider`. This lets downstream users enable rustls without forcing `aws-lc-rs` as the crypto provider, so they can install their own (e.g. `ring`). The existing `reqwest-rustls-tls` feature and the default feature set are unchanged, so this is purely additive. Part of: apache#7571
valkum
force-pushed
the
feat/reqwest-rustls-no-provider
branch
from
1b9a002 to
e5549f9
Compare
Contributor
Author
|
Taplo should be happy now. At least locally :) Fix is rebased into the commit to keep the history clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #7571.
Rationale for this change
#7365 placed a hard dependency on
aws-lc-rsby enabling thereqwest/rustlsfeature.This prevents downstream users from providing their own crypto provider such as
ring.What changes are included in this PR?
A new feature is added
reqwest-rustls-no-provider-tlswhich will forward toreqwestand enablesreqwests'srustls-no-providerfeature.The cargo tree output after applying this looks like:
There is apache/opendal-reqsign#754 to remove
aws-lc-rsfromreqsign-googleOther ideas floating around in #7571 are disabling any default HTTP client. This PR does not try to implement that.
Are there any user-facing changes?
The current
reqwest-rustlsfeature and the default feature set are unchanged.AI Usage Statement
I used Claude Code Opus 4.7 to review my state and impact before submitting.