Skip to content

fix(copy): add retry for copy operation#7595

Merged
Xuanwo merged 1 commit into
apache:mainfrom
dentiny:hjiang/fix-retry-copy
May 22, 2026
Merged

fix(copy): add retry for copy operation#7595
Xuanwo merged 1 commit into
apache:mainfrom
dentiny:hjiang/fix-retry-copy

Conversation

@dentiny
Copy link
Copy Markdown
Member

@dentiny dentiny commented May 22, 2026

Rationale for this change

We should wrap retry layer around copier-related operations.
Code implementation-wise, copier should mimic what we do for writer (any reason we don't do that?)

What changes are included in this PR?

Code change should be straightforward.

Are there any user-facing changes?

No

AI Usage Statement

opus 4.7 made the code change

@dentiny dentiny requested a review from Xuanwo as a code owner May 22, 2026 11:21
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. releases-note/fix The PR fixes a bug or has a title that begins with "fix" labels May 22, 2026
@dentiny
Copy link
Copy Markdown
Member Author

dentiny commented May 22, 2026

CC @Xuanwo I found we miss basically all the layering support for copier?
Apart from the two existing PRs (for retry and timeout), I plan to file a giant PR to add all missing layer support if you don't mind.

@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented May 22, 2026

CC @Xuanwo I found we miss basically all the layering support for copier? Apart from the two existing PRs (for retry and timeout), I plan to file a giant PR to add all missing layer support if you don't mind.

Yes, I'm open to this. They are all quite straightforward.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 22, 2026
@Xuanwo Xuanwo merged commit b6ceb59 into apache:main May 22, 2026
383 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/fix The PR fixes a bug or has a title that begins with "fix" size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants