fix(services/tos): Set user agent header#7598
Merged
Merged
Conversation
Change-Id: I3ff844b612becbb94fe24667a7d2646a9054c212
dosubot
Bot
added
size:S
Xuanwo
reviewed
May 22, 2026
| pub code: String, | ||
| pub message: String, | ||
| pub request_id: String, | ||
| fn insert_tos_user_agent_header(headers: &mut http::HeaderMap) { |
| } | ||
|
|
||
| pub async fn fetch(&self, req: Request<Buffer>) -> Result<Response<HttpBody>> { | ||
| pub async fn fetch(&self, mut req: Request<Buffer>) -> Result<Response<HttpBody>> { |
Member
There was a problem hiding this comment.
We can just impl under this line so we don't need to insert it twice.
Member
Author
There was a problem hiding this comment.
Thanks for the review, updated. User-Agent is added after signing so it won’t be part of the signature.
Change-Id: Ia4a6a8000fe769142587cd57dff12078415cfc19
dosubot
Bot
added
size:M
Xuanwo
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #7152.
Rationale for this change
Set OpenDAL User-Agent for TOS requests.
What changes are included in this PR?
User-Agent: opendal/{VERSION}in TOS send/fetch paths.Are there any user-facing changes?
No public API changes.
AI Usage Statement
This PR was implemented with OpenAI Codex.