[OPENJPA-2748] commons-collection is updated to most recent version

[solomax]

Additionally I would like to remove
ReferenceMap.HARD, SOFT, WEAK in favor of ReferenceStrength.HARD, SOFT, WEAK

shall I add another commit to this PR, or create another one?

this fix depends on commons-collections4 4.3-SNAPSHOT, will compile as soon as 4.3 will be released or SNAPSHOT will be uploaded

[ilgrosso]

Thx @solomax - this PR looks good to me.

I would like to remove ReferenceMap.HARD, SOFT, WEAK in favor of ReferenceStrength.HARD, SOFT, WEAK
shall I add another commit to this PR, or create another one?

To me, you can add that here.

@struberg / @rmannibucau would you please doublecheck?

[rmannibucau]

Looks ok to me (even adding a commit)
Side note: can be good to remove style/@OverRide changes since they are unrelated and take most of the diff

[solomax]

@rmannibucau I have this setting on by default in my IDE due to I had extremely bad experience of project migration without @OverRide being set.
Shall I remove all these annotations?

[rmannibucau]

@solomax if possible it would be awesome to have this PR about commons-collection upgrade only and then if you want add override everywhere

[solomax]

sure, will do
will take some time :)

[solomax]

Hopefully this diff will be easier to read :)

[ilgrosso]

Ok, I am going to merge this PR right now - but please don't forget to submit another for @overrides ;-)

[solomax]

@ilgrosso this will break the build ... most probably
4.3-SNAPSHOT might not be online ...

[ilgrosso]

@solomax let me check..

[ilgrosso]

@solomax ah I see: do you know why 4.3-SNAPSHOT is not there yet?

[solomax]

I'm afraid there no auto build :(
I've asked the devs: https://markmail.org/thread/tshcd4d54nxrvgbu

Will send additional email regarding SNAPSHOT

[ilgrosso]

@solomax could you please rebase?
Anyway, I cannot see yet commons-collections4's 4.3-SNAPSHOT artifacts out there.. :-(

[solomax]

@ilgrosso could you please guide me with rebase?
I never used it :(

[solomax]

I wrote another email regarding commons-collections4's 4.3-SNAPSHOT
no answer yet :(

[ilgrosso]

could you please guide me with rebase?
I never used it :(

I mean something like as https://robots.thoughtbot.com/keeping-a-github-fork-updated

[solomax]

Just have tried to rebase but no luck :(
rebase against solomax/trunk has no effect
rebase against apache/trunk conflicts and I have no idea how to resolve it :(

[ilgrosso]

rebase against apache/trunk conflicts and I have no idea how to resolve it :(

yep, you should rebasing against apache/trunk and solving the conflicts :-)
There have been no changes in trunk but yours, so I think you should be able to cope with those...

[solomax]

OK, the trick was to use git rebase --skip :)
But for some reason there are still 3 commits :(

[ilgrosso]

But for some reason there are still 3 commits :(

This could be fixed too, but it is not really a big issue since we are with SVN.

[solomax]

Great :)

[ilgrosso]

ah, it seems you can merge this PR by yourself, when the commons-collection4 artifacts will be available ;-)
congrats!

[solomax]

Sure, will do :)
But I would like to perform contributions via PRs (at least for the first time)
Would it be OK?

[ilgrosso]

But I would like to perform contributions via PRs (at least for the first time)
Would it be OK?

I don't see any issue with that.

[solomax]

Great, so will do the merge as soon as SNAPSHOT will be available
Thanks for the help!

[solomax]

Merged with 4709f38