[2.2.x] OPENJPA-2790: Convert build from SVN to GIT #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dazey3
reviewed
Jun 20, 2019
openjpa-lib/pom.xml
Outdated
| <exec outputproperty="git.diff.exitval" resultproperty="diff.state" failonerror="false" failifexecutionfails="false" executable="git"> | ||
| <arg line="diff --quiet HEAD" /> | ||
| </exec> | ||
| <condition property="uncommitted.changes" value="M"> |
Contributor
There was a problem hiding this comment.
How about?:
<condition property="uncommitted.changes" value="M" else="">
Contributor
Author
There was a problem hiding this comment.
That works for me too.
ilgrosso
approved these changes
Jun 21, 2019
Member
ilgrosso
left a comment
ilgrosso
left a comment
There was a problem hiding this comment.
LGTM, please go ahead and propose PRs for 2.4.x and master branches too, thanks.
This change ensures that git hashes have a length of 7 (observed different default lengths between different versions of git), and restores the "M" at the end of the revision number to signify "dirty" OpenJPA builds. Signed-off-by: Joe Grassel <jgrassel@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/OPENJPA-2790
This change ensures that git hashes have a length of 7 (observed different default lengths between different versions of git), and restores the "M" at the end of the revision number to signify "dirty" OpenJPA builds.