Skip to content

OpenNLP-977 Remove deprecated map methods#110

Closed
danielruss wants to merge 1 commit intoapache:masterfrom
danielruss:OpenNLP977
Closed

OpenNLP-977 Remove deprecated map methods#110
danielruss wants to merge 1 commit intoapache:masterfrom
danielruss:OpenNLP977

Conversation

@danielruss
Copy link
Contributor

removed many .getSettings() to use the TrainingParameters methods and not the Map methods. added init(TrainingParameter,Map<String,String>) method to interfaces.

@kottmann
Copy link
Member

kottmann commented Feb 6, 2017

The commit message should be:
OPENNLP-977: Remove deprecated map methods

@danielruss danielruss changed the title OpenNLP977 remove deprecated map methods OpenNLP-977 remove deprecated map methods Feb 6, 2017
@danielruss danielruss changed the title OpenNLP-977 remove deprecated map methods OpenNLP-977 Remove deprecated map methods Feb 6, 2017
@smarthi
Copy link
Member

smarthi commented Feb 7, 2017

+1 lgtm

@danielruss
Copy link
Contributor Author

Forgot the add "This closes #110" to the message. Manually closing the PR and the JIRA.

@danielruss danielruss closed this Feb 7, 2017
danielruss added a commit to danielruss/opennlp that referenced this pull request Feb 9, 2017
@danielruss danielruss deleted the OpenNLP977 branch February 9, 2017 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants