OPENNLP-975: Add format support for CoNLL-U format #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kottmann
changed the title
kottmann
force-pushed
the
OPENNLP-975
branch
2 times, most recently
from
6dd2a1a to
28d53b7
Compare
smarthi
reviewed
Feb 7, 2017
| try { | ||
| return new ConlluLemmaSampleStream(new ConlluStream(inFactory), tagset); | ||
| } | ||
| catch (IOException e) { |
Member
There was a problem hiding this comment.
cosmetic: move the catch line to prevous line following }
smarthi
reviewed
Feb 7, 2017
| catch (IOException e) { | ||
| // That will throw an exception | ||
| CmdLineUtil.handleCreateObjectStreamError(e); | ||
| return null; |
Member
There was a problem hiding this comment.
this can be moved out of catch{} as the final return from the method
smarthi
reviewed
Feb 7, 2017
| } catch (IOException e) { | ||
| // That will throw an exception | ||
| CmdLineUtil.handleCreateObjectStreamError(e); | ||
| return null; |
Member
There was a problem hiding this comment.
move this outside catch {} as final return
smarthi
reviewed
Feb 7, 2017
| String line; | ||
| while ((line = reader.readLine()) != null) { | ||
| // comment line, skip it | ||
| if (line.trim().startsWith("#")) { |
Member
There was a problem hiding this comment.
invert the if condition and hence avoid continue;
Change to if (!line.trim().startsWith("#")) { wordLines.add(new ...) }
smarthi
reviewed
Feb 7, 2017
|
|
||
| ConlluTagset tagset; | ||
|
|
||
| if ("u".equals(params.getTagset())) { |
Member
There was a problem hiding this comment.
can this be replaced by a switch stmt? and avoid f-then-else
smarthi
reviewed
Feb 7, 2017
| tagset = ConlluTagset.X; | ||
| } | ||
| else { | ||
| // unkown type |
Member
There was a problem hiding this comment.
this could go in as default condition in a switch stmt
smarthi
reviewed
Feb 7, 2017
| * @param tagset the type of tag to retrieve, either universial (u) or language specific (x) | ||
| */ | ||
| public String getPosTag(ConlluTagset tagset) { | ||
| if (ConlluTagset.U.equals(tagset)) { |
Member
Author
|
Yeah, using switch makes it much nicer because I don't have to call equals by hand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.