Skip to content

OPENNLP-125: Make POS Tagger feature generation configurable #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asfgit merged 1 commit into from
Mar 8, 2017
Merged

OPENNLP-125: Make POS Tagger feature generation configurable #120

asfgit merged 1 commit into from
Mar 8, 2017

Conversation

@kottmann
Copy link
Member

@kottmann kottmann commented Feb 9, 2017

No description provided.

@kottmann kottmann force-pushed the OPENNLP-125 branch 8 times, most recently from 28a6754 to 1ab295f Compare February 16, 2017 13:28
kottmann
kottmann commented Feb 16, 2017
View reviewed changes
opennlp-tools/src/main/java/opennlp/tools/postag/TheNewPOSContextGenerator.java Outdated
e.add("t2=" + tagprevprev + "," + tagprev);
}
}
}
Copy link
Member Author

@kottmann kottmann Feb 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remaining feature generation here has still to be moved to a dedicated feature generator.

@kottmann kottmann force-pushed the OPENNLP-125 branch 2 times, most recently from 0a82144 to 76e1471 Compare February 17, 2017 21:52
@smarthi
Copy link
Member

smarthi commented Feb 23, 2017

+1 lgtm

@coveralls
Copy link

coveralls commented Feb 28, 2017

Coverage Status

Coverage decreased (-0.03%) to 51.807% when pulling 987e768 on kottmann:OPENNLP-125 into c17c551 on apache:master.

@coveralls
Copy link

coveralls commented Mar 1, 2017

Coverage Status

Coverage increased (+0.06%) to 54.934% when pulling 134660d on kottmann:OPENNLP-125 into f60bfa2 on apache:master.

@smarthi
Copy link
Member

smarthi commented Mar 1, 2017

Maybe a good idea to add any missing tests as part of this PR for this code.

@coveralls
Copy link

coveralls commented Mar 2, 2017

Coverage Status

Coverage increased (+0.06%) to 54.934% when pulling f8218f0 on kottmann:OPENNLP-125 into f60bfa2 on apache:master.

@coveralls
Copy link

coveralls commented Mar 4, 2017

Coverage Status

Coverage increased (+0.06%) to 54.89% when pulling afc64b3 on kottmann:OPENNLP-125 into 8a3b3b5 on apache:master.

@kottmann kottmann force-pushed the OPENNLP-125 branch 2 times, most recently from 7f88ac5 to 5783340 Compare March 7, 2017 10:40
@kottmann kottmann changed the title [WIP] OPENNLP-125: Make POS Tagger feature generation configurable OPENNLP-125: Make POS Tagger feature generation configurable Mar 7, 2017
@coveralls
Copy link

coveralls commented Mar 7, 2017

Coverage Status

Coverage increased (+0.08%) to 54.906% when pulling 2cf2ec5 on kottmann:OPENNLP-125 into 347babe on apache:master.

@coveralls
Copy link

coveralls commented Mar 7, 2017

Coverage Status

Coverage increased (+0.08%) to 54.906% when pulling 2cf2ec5 on kottmann:OPENNLP-125 into 347babe on apache:master.

@coveralls
Copy link

coveralls commented Mar 7, 2017

Coverage Status

Coverage increased (+0.08%) to 54.906% when pulling 2cf2ec5 on kottmann:OPENNLP-125 into 347babe on apache:master.

@coveralls
Copy link

coveralls commented Mar 7, 2017

Coverage Status

Coverage increased (+0.08%) to 54.906% when pulling 530432c on kottmann:OPENNLP-125 into 347babe on apache:master.

@wcolen
Copy link
Member

wcolen commented Mar 8, 2017

+1 lgtm

@asfgit asfgit merged commit 530432c into apache:master Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kottmann @smarthi @coveralls @wcolen @asfgit