OPENNLP-1000: Write a test case for the BilouNameFinderSequenceValidator class #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage increased (+0.1%) to 55.043% when pulling d59e825 on thygesen:opennlp-1000 into a9cfd7e on apache:master. |
Member
|
The changes look good, but we still need to update the commit message before merging this. |
Member
|
We need to run the validation tests once with those fixes applied and if not present add some. |
wcolen
reviewed
Mar 13, 2017
Member
wcolen
left a comment
wcolen
left a comment
There was a problem hiding this comment.
+1 lgtm (reduce the commit message length)
Contributor
Author
|
pls. let me know if you need me to do something. |
Member
|
No, this is good, I just need to run the tests and I will also rewrite the commit message (should contain the issue) |
asfgit
pushed a commit
that referenced
this pull request
Apr 16, 2017
asfgit
pushed a commit
that referenced
this pull request
Apr 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a test for the BilouNameFinderSequenceValidator. It proved to have bugs according to my tests and I therefore also fixed NameFinderSequenceValidator. Should this have been a separate PR/JIRA?