Skip to content

Conversation

@smarthi
Copy link
Member

@smarthi smarthi commented Apr 15, 2017

…l to database'

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 55.883% when pulling d2a6667 on smarthi:OPENNLP-1022 into b188b5c on apache:master.

@wcolen
Copy link
Member

wcolen commented Apr 16, 2017

+1 lgtm

Copy link
Member

@kottmann kottmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 lgtm

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 55.89% when pulling 6bdb480 on smarthi:OPENNLP-1022 into 4efd950 on apache:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 55.975% when pulling c13339f on smarthi:OPENNLP-1022 into e76ba36 on apache:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 56.243% when pulling 8b493e4 on smarthi:OPENNLP-1022 into 2721401 on apache:master.

@wcolen
Copy link
Member

wcolen commented Apr 17, 2017

+1 LGTM

@asfgit asfgit closed this in f8fbfc9 Apr 17, 2017
@smarthi smarthi deleted the OPENNLP-1022 branch April 17, 2017 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants