OPENNLP-1024: Add unit tests and javadocs for DirectorySampleStream.

[jzonthemtn]

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

• Is there a JIRA ticket associated with this PR? Is it referenced
  in the commit message?

• Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

• Has your PR been rebased against the latest commit within the target branch (typically master)?

• Is your initial contribution a single, squashed commit?

For code changes:

• Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
• Have you written or updated unit tests to verify your changes?
• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
• If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

• Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

[smarthi]

We have a recent very nitty checkstyle to avoid static imports :-)

[jzonthemtn]

I'll fix that. I don't think checkstyle complained during my build. Should it have?

[smarthi]

no need to define the type on RHS, replace by diamond <>

[coveralls]

Coverage increased (+0.2%) to 56.074% when pulling cce36ea on jzonthemtn:OPENNLP-1024 into 4efd950 on apache:master.

[smarthi]

We didn't enable that in checkstyle, but we have been cognizant about avoiding static imports since 1.7.0 release. Please go ahead and make the change - sorry for being nitpicky

…

On Sat, Apr 15, 2017 at 5:00 PM, Jeff ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In opennlp-tools/src/test/java/opennlp/tools/formats/ DirectorySampleStreamTest.java <#160 (comment)>: > + +package opennlp.tools.formats; + +import java.io.File; +import java.io.FileFilter; +import java.io.IOException; +import java.util.ArrayList; +import java.util.List; + +import org.junit.Rule; +import org.junit.Test; +import org.junit.rules.TemporaryFolder; + +import static org.junit.Assert.assertNull; +import static org.junit.Assert.assertTrue; + I'll fix that. I don't think checkstyle complained during my build. Should it have? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#160 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC_fot7eeBSs4UgcLXNB6_Z2GOjipCDCks5rwS_lgaJpZM4M-dNh> .

[coveralls]

Coverage increased (+0.2%) to 56.074% when pulling 8bf7389 on jzonthemtn:OPENNLP-1024 into 4efd950 on apache:master.

[wcolen]

+1 LGTM