OPENNLP-1035: Adds unit tests for BrownBigramFeatureGenerator. #174
Conversation
|
Coverage increased (+0.2%) to 57.102% when pulling 6114b9c on jzonthemtn:OPENNLP-1035 into 3ba27e9 on apache:master. |
|
|
||
| ResourceAsStreamFactory stream = new ResourceAsStreamFactory( | ||
| getClass(), "/opennlp/tools/formats/brown-cluster.txt"); | ||
|
|
There was a problem hiding this comment.
could we refactor the above into a setUp() method and not having to repeat for each test
There was a problem hiding this comment.
Sure. Simplifies things a bit.
| 00010 Rue-de-Grandes-Illusions 1 | ||
| 00010 good. 1 | ||
| 00010 Barmerstr. 1 | ||
| 00010 B�rgerstra�e 1 |
There was a problem hiding this comment.
Do we have an encoding issue here?
There was a problem hiding this comment.
I generated that from AnnotatedSentences.txt and it looks like it has those characters. Since those lines weren't needed for these tests I just removed them.
jzonthemtn
force-pushed
the
OPENNLP-1035
branch
from
6114b9c to
988001f
Compare
|
Coverage increased (+0.2%) to 57.269% when pulling 988001f on jzonthemtn:OPENNLP-1035 into f74a86f on apache:master. |
|
|
||
| String[] tokens = new String[] {"he", "went", "with", "you"}; | ||
|
|
||
| AdaptiveFeatureGenerator generator = new BrownBigramFeatureGenerator(brownCluster); |
There was a problem hiding this comment.
This line can be moved up to the @before method too.
| private BrownCluster brownCluster; | ||
|
|
||
| @Before | ||
| public void before() throws IOException { |
There was a problem hiding this comment.
nitpick: call this method setUp() ?
There was a problem hiding this comment.
Got them. Thanks.
jzonthemtn
force-pushed
the
OPENNLP-1035
branch
from
988001f to
3ed710b
Compare
|
+1 lgtm, will merge now |
|
Coverage increased (+0.2%) to 57.363% when pulling 3ed710b on jzonthemtn:OPENNLP-1035 into 4060217 on apache:master. |
4 participants
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.