Skip to content

OPENNLP-1041: Verify test data before running tests #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kottmann wants to merge 2 commits into from
Closed

OPENNLP-1041: Verify test data before running tests #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
065a629
OPENNLP-1043: Ensure files are always loaded in same order
kottmann Apr 21, 2017
32afb6a
OPENNLP-1041: Verify test data before running tests
kottmann Apr 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions opennlp-tools/src/main/java/opennlp/tools/formats/DirectorySampleStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import java.io.FileFilter;
import java.io.IOException;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import java.util.Stack;
Expand Down Expand Up @@ -95,6 +96,8 @@ public File read() throws IOException {
files = dir.listFiles();
}

Arrays.sort(files);

for (File file : files) {
if (file.isFile()) {
textFiles.push(file);
Expand Down Expand Up @@ -128,7 +131,5 @@ public void reset() {
*/
@Override
public void close() throws IOException {

}

}
2 changes: 1 addition & 1 deletion opennlp-tools/src/test/java/opennlp/tools/eval/OntoNotes4NameFinderEval.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ private static void crossEval(TrainingParameters params, String type, double exp
@Test
public void evalEnglishPersonNameFinder() throws IOException {
TrainingParameters params = ModelUtil.createDefaultTrainingParameters();
crossEval(params, "person", 0.8299903903167106d);
crossEval(params, "person", 0.8286204642039883d);
}

@Test
Expand Down
2 changes: 1 addition & 1 deletion opennlp-tools/src/test/java/opennlp/tools/eval/OntoNotes4PosTaggerEval.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,6 @@ private static void crossEval(TrainingParameters params, double expectedScore)

@Test
public void evalEnglishMaxentTagger() throws IOException {
crossEval(ModelUtil.createDefaultTrainingParameters(), 0.9699561275750962d);
crossEval(ModelUtil.createDefaultTrainingParameters(), 0.9698145168879707d);
}
}
5 changes: 3 additions & 2 deletions opennlp-tools/src/test/java/opennlp/tools/eval/SourceForgeModelEval.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import java.security.NoSuchAlgorithmException;

import org.junit.Assert;
import org.junit.BeforeClass;
import org.junit.Test;

import opennlp.tools.chunker.Chunker;
Expand Down Expand Up @@ -89,8 +90,8 @@ private static MessageDigest createDigest() {
}
}

@Test
public void ensureTestDataIsCorrect() throws IOException {
@BeforeClass
public static void ensureTestDataIsCorrect() throws IOException {
MessageDigest digest = createDigest();

try (ObjectStream<String> lines = new PlainTextByLineStream(
Expand Down