Skip to content

Conversation

@kottmann
Copy link
Member

@kottmann kottmann commented Apr 21, 2017

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Copy link
Member

@smarthi smarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 lgtm

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 57.053% when pulling e4062cc on kottmann:opennlp-1043 into f74a86f on apache:master.

@kottmann
Copy link
Member Author

Don't merge this, we probably need to update a few test results first.

@kottmann kottmann force-pushed the opennlp-1043 branch 2 times, most recently from 79c7b9e to a172c23 Compare April 24, 2017 08:26
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 57.145% when pulling 13ce0f1 on kottmann:opennlp-1043 into 735b1b5 on apache:master.

@kottmann kottmann changed the title [WIP] OPENNLP-1043: Ensure files are always loaded in same order OPENNLP-1043: Ensure files are always loaded in same order Apr 24, 2017
@kottmann kottmann closed this Apr 24, 2017
kottmann added a commit to kottmann/opennlp that referenced this pull request Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants