OPENNLP-1272: Add support for Catalan and Indonesian stemmers #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se Distribution Process. (#343) OPENNLP-1236: Add arabic and greek stemmers support fixed tests Added opennlp support for Indonesian and Catalan languages. Normal ⋅⋅* Two files were added for the stemmers. ⋅⋅* SnowballProgram.java was changed due to a problem. ⋅⋅* From now on, if a new language which has exception functions in the Among arrays (at the moment only finnish and indonesian have this), in the SnowballStemmer.java, the stemmer needs to be declared using stemmer=stemmer.methodObject(); instead of using the 'new' keyword. Not applicable. The risks include the fact that the stemming process might not give the correct results, which would result in bad performance. N/A back-end modification. Unit tests have been added for Indonesian and Catalan and all tests pass successfully. No deployments considerations. Added opennlp support for Indonesian and Catalan languages. Normal ⋅⋅* Two files were added for the stemmers. ⋅⋅* SnowballProgram.java was changed due to a problem. ⋅⋅* From now on, if a new language which has exception functions in the Among arrays (at the moment only finnish and indonesian have this), in the SnowballStemmer.java, the stemmer needs to be declared using stemmer=stemmer.methodObject(); instead of using the 'new' keyword. Not applicable. The risks include the fact that the stemming process might not give the correct results, which would result in bad performance. N/A back-end modification. Unit tests have been added for Indonesian and Catalan and all tests pass successfully. No deployments considerations. Validation ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.