Skip to content

OPENNLP-1397: Build should fail fast if an unsupported JDK is used#437

Merged
smarthi merged 1 commit intoapache:masterfrom
smarthi:OPENNLP-1397
Nov 23, 2022
Merged

OPENNLP-1397: Build should fail fast if an unsupported JDK is used#437
smarthi merged 1 commit intoapache:masterfrom
smarthi:OPENNLP-1397

Conversation

@smarthi
Copy link
Copy Markdown
Member

@smarthi smarthi commented Nov 23, 2022

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

@smarthi smarthi requested a review from jzonthemtn November 23, 2022 00:37
@smarthi smarthi self-assigned this Nov 23, 2022
@smarthi smarthi merged commit c13b35a into apache:master Nov 23, 2022
@smarthi smarthi deleted the OPENNLP-1397 branch November 23, 2022 01:02
@jzonthemtn
Copy link
Copy Markdown
Contributor

Thanks @smarthi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants