Skip to content

OPENNLP-1341: Fix make the conllu pos sample stream constructor public#440

Merged
kinow merged 1 commit into
apache:masterfrom
mawiesne:OPENNLP-1341_Fix_Make_the_ConlluPOSSampleStream_constructor_public
Nov 30, 2022
Merged

OPENNLP-1341: Fix make the conllu pos sample stream constructor public#440
kinow merged 1 commit into
apache:masterfrom
mawiesne:OPENNLP-1341_Fix_Make_the_ConlluPOSSampleStream_constructor_public

Conversation

@mawiesne
Copy link
Copy Markdown
Contributor

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

- adds missing `public` modifier for `ConlluPOSSampleStream` to be consistent with `ConlluLemmaSampleStream` and similar ones
- adds missing JavaDoc on 'internal use only' for `ConlluSentenceSampleStreamFactory` and `ConlluTokenSampleStreamFactory`
@mawiesne
Copy link
Copy Markdown
Contributor Author

@kinow It's now reduced to a single commit.

@kinow kinow merged commit 003b73f into apache:master Nov 30, 2022
@kinow
Copy link
Copy Markdown
Member

kinow commented Nov 30, 2022

Thanks @mawiesne . I've marked the JIRA as resolved, and set the fix version to 2.1.1. Merged 👍 🚀

@mawiesne mawiesne deleted the OPENNLP-1341_Fix_Make_the_ConlluPOSSampleStream_constructor_public branch November 30, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants