OPENNLP-1332: Fix default chunker context generator has inconsistent format#441
Closed
mawiesne wants to merge 9 commits into
apache:masterfrom
mawiesne:OPENNLP-1332/Fix_Default_chunker_context_generator_has_inconsistent_format
Closed
OPENNLP-1332: Fix default chunker context generator has inconsistent format#441mawiesne wants to merge 9 commits intoapache:masterfrom mawiesne:OPENNLP-1332/Fix_Default_chunker_context_generator_has_inconsistent_format
mawiesne wants to merge 9 commits into
apache:masterfrom
mawiesne:OPENNLP-1332/Fix_Default_chunker_context_generator_has_inconsistent_format
Conversation
- eliminates several compiler warnings by more consequent use of generic types - reduces use of deprecated api calls to external deps - introduces Sample interface as a marker for similar impl classes - introduces Trainer interface as a marker for similar impl classes - adapts previously deprecated methods in AbstractTrainer - removes deprecated constructor 'TrainingParameters(Map<String,String> map)' in favor of 'public TrainingParameters(Map<String,Object> map)' - removes deprecated methods in TrainingParameters
- eliminates more compiler warnings related to raw use of parameterized types - reduces use of deprecated api calls to external deps - removes orphaned methods / constructors that where not used or not required anymore - fixes typos and improves JavaDoc
This reverts commit ced4854.
# Conflicts: # opennlp-tools/src/test/java/opennlp/tools/convert/FileToStringSampleStreamTest.java # opennlp-tools/src/test/java/opennlp/tools/formats/ad/ADTokenSampleStreamTest.java # opennlp-tools/src/test/java/opennlp/tools/languagemodel/NgramLanguageModelTest.java # opennlp-tools/src/test/java/opennlp/tools/ml/ArrayMathTest.java # opennlp-tools/src/test/java/opennlp/tools/ml/MockSequenceTrainer.java # opennlp-tools/src/test/java/opennlp/tools/postag/POSTaggerFactoryTest.java # opennlp-tools/src/test/java/opennlp/tools/util/TrainingParametersTest.java
- adapts to changes brought by OPENNLP-1361 (-> JUnit5), fixes compile error
- fixes missing equals sign
…enerator_has_inconsistent_format
rzo1
approved these changes
Nov 28, 2022
kinow
reviewed
Nov 28, 2022
Member
kinow
left a comment
kinow
left a comment
There was a problem hiding this comment.
+1! Maybe we could squash the commits? I think this PR has 9 commits for this small change? Thanks!
Contributor
Author
|
Closing this PR due to naming conflict in git branch. Reopen will follow from separate, consistent topic branch. |
mawiesne
deleted the
OPENNLP-1332/Fix_Default_chunker_context_generator_has_inconsistent_format
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.