Skip to content

OPENNLP-1411 Provide equals and hashCode for POSModel#457

Merged
rzo1 merged 1 commit intoapache:masterfrom
mawiesne:OPENNLP-1411_Provide_equals_and_hashCode_for_POSModel
Dec 14, 2022
Merged

OPENNLP-1411 Provide equals and hashCode for POSModel#457
rzo1 merged 1 commit intoapache:masterfrom
mawiesne:OPENNLP-1411_Provide_equals_and_hashCode_for_POSModel

Conversation

@mawiesne
Copy link
Copy Markdown
Contributor

@mawiesne mawiesne commented Dec 11, 2022

Change

  • adds specific equals and hashCode implementations for POSModel, GISModel, and PerceptronModel.
  • improves POSModelTest by adding further assertions and fixes two open TODOs.
  • adds 'Override' where applicable

Tasks

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

- adds specific `equals` and `hashCode` implementations for `POSModel`, `GISModel`, and `PerceptronModel`.
- improves `POSModelTest` by adding further assertions and fixes to open TODOs.
- adds 'Override' where applicable
@rzo1 rzo1 merged commit 59f10a2 into apache:master Dec 14, 2022
@mawiesne mawiesne deleted the OPENNLP-1411_Provide_equals_and_hashCode_for_POSModel branch December 15, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants