OPENNLP-1423 Enhance JavaDoc in opennlp.tools.ml package#469
Merged
mawiesne merged 1 commit intoapache:mainfrom Dec 27, 2022
mawiesne:OPENNLP-1423_Enhance_JavaDoc_in_opennlp.tools.ml_package
Merged
OPENNLP-1423 Enhance JavaDoc in opennlp.tools.ml package#469mawiesne merged 1 commit intoapache:mainfrom mawiesne:OPENNLP-1423_Enhance_JavaDoc_in_opennlp.tools.ml_package
mawiesne merged 1 commit intoapache:mainfrom
mawiesne:OPENNLP-1423_Enhance_JavaDoc_in_opennlp.tools.ml_package
Conversation
Contributor
Author
|
That's my Merry Xmas PR for 2022 🎄🌟 |
kinow
approved these changes
Dec 23, 2022
Member
kinow
left a comment
kinow
left a comment
There was a problem hiding this comment.
Whew, 90 files. Started reviewing it until I realized the number of files.
Fast-scrolled through some random files, and found nothing that looked strange or wrong.
And given your record of great PR's, I'd say +1 LGTM.
Thanks a lot, merry x-mas @mawiesne & y'all!
rzo1
approved these changes
Dec 23, 2022
opennlp-tools/src/main/java/opennlp/tools/ml/model/AbstractDataIndexer.java
Show resolved
Hide resolved
- adds missing JavaDoc for `opennlp.tools.ml` - improves existing documentation for clarity - removes superfluous text - adds 'final' modifier where useful and applicable - adds 'Override' annotation where useful and applicable - adds `package-info.java` files for several sub-packages - simplifies several constructors, removing duplicate code - fixes several typos - marks AbstractTrainer.init(..) method to as deprecated - addresses PR review comments
rzo1
approved these changes
Dec 26, 2022
mawiesne
deleted the
OPENNLP-1423_Enhance_JavaDoc_in_opennlp.tools.ml_package
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
opennlp.tools.mlpackage-info.javafiles for several sub-packagesTasks
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.