OPENNLP-1434 Enhance JavaDoc in opennlp.uima packages#479
Merged
jzonthemtn merged 2 commits intoapache:mainfrom Jan 3, 2023
mawiesne:OPENNLP-1434_Enhance_JavaDoc_in_opennlp.uima_packages
Merged
OPENNLP-1434 Enhance JavaDoc in opennlp.uima packages#479jzonthemtn merged 2 commits intoapache:mainfrom mawiesne:OPENNLP-1434_Enhance_JavaDoc_in_opennlp.uima_packages
jzonthemtn merged 2 commits intoapache:mainfrom
mawiesne:OPENNLP-1434_Enhance_JavaDoc_in_opennlp.uima_packages
Conversation
kinow
reviewed
Jan 2, 2023
opennlp-uima/src/main/java/opennlp/uima/doccat/DocumentCategorizer.java
Outdated
Show resolved
Hide resolved
opennlp-uima/src/main/java/opennlp/uima/doccat/LanguageDetector.java
Outdated
Show resolved
Hide resolved
- adds missing JavaDoc - improves existing documentation for clarity - removes superfluous text - adds test-scoped dependency to slf4j-simple logger binding to avoid NOOP error messages when UIMA tests are run - adds 'final' modifier where useful and applicable - adds 'Override' annotation where useful and applicable - fixes several (funny) typos, eg in `ExceptionMessages`
kinow
approved these changes
Jan 2, 2023
jzonthemtn
approved these changes
Jan 2, 2023
rzo1
approved these changes
Jan 2, 2023
| * @param remove The {@link Character} to remove from {@code s}. | ||
| */ | ||
| private static String removeChar(String string, char remove) { | ||
| private static String removeChar(String s, char remove) { |
Contributor
There was a problem hiding this comment.
This is basically a s.replace(remove, "") (replace all occurences of the given char in the given String literal). Sadly, were is no String#replace(char,String) available, but we could do s.replace(Character.toString(remove), "") (or change the method signature). No blocker, but would reduce code complexity.
Contributor
There was a problem hiding this comment.
Alternative: As the method is private and only used for removing ' ' from a given String, we could avoid dealing with the hell of whitespace and just replace it with a call to s.replaceAll("\\s+", ""); ?
Contributor
There was a problem hiding this comment.
Since that's more than a Javadoc change and so we can merge this, I wrote OPENNLP-1437 to change the function.
…lp.uima_packages
jzonthemtn
approved these changes
Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
ExceptionMessagesTasks
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.