Skip to content

Conversation

@rzo1
Copy link
Contributor

@rzo1 rzo1 commented Oct 14, 2025

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

When an abbreviation appears at the beginning of a sentence, OpenNLP 2.5.6's SentenceDetectorME can throw a java.lang.StringIndexOutOfBoundsException.

This is a regression from https://issues.apache.org/jira/browse/OPENNLP-1767

@rzo1 rzo1 requested a review from mawiesne October 14, 2025 09:22
@rzo1 rzo1 added java Pull requests that update Java code tests Pull requests that add or update test code labels Oct 14, 2025
@rzo1 rzo1 force-pushed the OPENNLP-1781-port branch from 031aea5 to 1de789e Compare October 14, 2025 09:26
…ion when sentence starts with an abbreviation
@rzo1 rzo1 force-pushed the OPENNLP-1781-port branch from 1de789e to c737998 Compare October 14, 2025 09:28
@mawiesne mawiesne changed the title OPENNLP-1781 - SentenceDetectorME throws StringIndexOutOfBoundsException when sentence starts with an abbreviation OPENNLP-1781: SentenceDetectorME throws StringIndexOutOfBoundsException when sentence starts with an abbreviation Oct 14, 2025
@mawiesne mawiesne merged commit 140198f into main Oct 14, 2025
12 checks passed
@mawiesne mawiesne deleted the OPENNLP-1781-port branch October 14, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java Pull requests that update Java code tests Pull requests that add or update test code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants