fix: add secrets and pods RBAC rules for admin-api builder#200
Open
Bi-Gen wants to merge 1 commit into
Open
Conversation
The deployer (admin-api builder) requires access to secrets and pods that are not included in the current wsku role definition. Secrets are used by build_service.py: - create_registry_secret() for docker registry auth - get_secret() to read registry credentials - delete_secret() to clean up after build Pods are used by kube_api_client.py: - get_pod_by_job_name() to find the buildkit job pod - stream_pod_logs() to monitor build progress - get_pod() to check pod status Mirrors apache/openserverless-operator#101. Tested on k3s (lorenzo1) with Cotemar pipeline deployment. Related: nuvolaris/projects#409
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The deployer (admin-api builder) requires RBAC access to
secretsandpodsresources that are missing from the currentnuvolaris-wsku-roledefinition.Mirrors apache/openserverless-operator#101 — keeping both copies of the file in sync.
Added rules
Secrets (full CRUD):
build_service.py:create_registry_secret()for docker registry auth,get_secret()to read registry credentials,delete_secret()to clean up after buildPods and pods/log (read-only):
kube_api_client.py:get_pod_by_job_name()to find the buildkit job pod,stream_pod_logs()to monitor build progress,get_pod()to check pod statusTest plan
Related: nuvolaris/projects#409