Bug fix: Use configured prototcol for API requests#300
Merged
dubee merged 1 commit intoapache:masterfrom May 30, 2018
Merged
Conversation
dgrove-oss
force-pushed
the
avoid-double-https-in-api-create
branch
from
c321dda to
db17116
Compare
dubee
reviewed
May 18, 2018
Member
dubee
left a comment
dubee
left a comment
There was a problem hiding this comment.
@dgrove-oss, is it possible to write a test for this?
Member
|
@mdeuser, FYI. |
dgrove-oss
force-pushed
the
avoid-double-https-in-api-create
branch
from
db17116 to
5e4b7b5
Compare
Add check to see if Client.Config.Host already specifies the protocol to use before prepending https:// in URL construction. Fixes a bug where if .wskprops specifies a APIHOST with a protocol, `wsk api create` generates an invalid backend URL (https://https://APIHOST/...). Also add unit test to check for this error condition. Fixes apache#125.
dgrove-oss
force-pushed
the
avoid-double-https-in-api-create
branch
from
7480066 to
155de29
Compare
Member
Author
|
@dubee -- I added a test. I think this is ready for final review & merge now. |
dubee
approved these changes
May 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add check to see if Client.Config.Host already specifies the protocol
to use before prepending https:// in URL construction.
Fixes a bug where if .wskprops specifies a APIHOST with a protocol,
wsk api creategenerates an invalid backend URL (https://https://APIHOST/...).Fixes #125.