Refactor action invoke functions #319
Merged
houshengbo merged 7 commits intoapache:masterfrom Jun 18, 2018
Merged
Conversation
Member
Author
|
this is semantic preserving - and permits some further refactoring down the line to fix the referenced bug, which is part of #315 but is turning out to be fairly substantial so I am breaking things up into smaller pieces. |
rabbah
force-pushed
the
feed
branch
12 times, most recently
from
c506c29 to
24b1b52
Compare
Member
Author
|
@csantanapr @dubee @houshengbo @mdeuser @pritidesai may I get one of you to look at this and approve a review 🙏 ? |
rabbah
force-pushed
the
feed
branch
3 times, most recently
from
a556ed2 to
24de468
Compare
dubee
reviewed
Jun 14, 2018
| parameters interface{}, | ||
| blocking bool, | ||
| result bool) (map[string]interface{}, error) { | ||
| // TODO remove all global modifiers |
Member
Author
There was a problem hiding this comment.
My intention is to remove all Client. and Flags. assignments where for the latter beyond the initial parsing should be viewed as immutable.
This permits invoking an action without access to global pamareters and bypassing parameter passing. Caller will be responsible for passing in the appropriate paramters, as in the case of a feed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This permits a caller to determine how it wants to handle the action activation response. This is toward removing the feed output when creating a trigger with a feed.
The commits are all grouped and incremental for ease of reviewing.
This is related to fixing #134.