Create triggers on update if do not exist #353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Vadim thank you for taking this and adding proper unit test - this will help us improve the cli’s enginnering. I’m all for it. |
dubee
reviewed
Aug 10, 2018
dubee
reviewed
Aug 10, 2018
dubee
reviewed
Aug 10, 2018
Member
dubee
left a comment
dubee
left a comment
There was a problem hiding this comment.
Merged the related Go client PR.
vvraskin
force-pushed
the
triggers
branch
4 times, most recently
from
0a3f7cf to
0ffa47c
Compare
dubee
reviewed
Aug 20, 2018
dubee
reviewed
Jan 4, 2019
| * NOTE: this function will exit in case of a processing error since it indicates a problem parsing parameters. | ||
| */ | ||
| func createOrUpdate(fqn *QualifiedName, trigger *whisk.Trigger, overwrite bool) { | ||
| func createOrUpdate(Client *whisk.Client, fqn *QualifiedName, trigger *whisk.Trigger, overwrite bool) { |
Member
There was a problem hiding this comment.
Now that Client is a parameter, can we delete the comment // TODO get rid of these global modifiers?
rabbah
approved these changes
Jan 26, 2019
| * NOTE: this function will exit in case of a processing error since it indicates a problem parsing parameters. | ||
| */ | ||
| func createOrUpdate(fqn *QualifiedName, trigger *whisk.Trigger, overwrite bool) { | ||
| func createOrUpdate(Client *whisk.Client, fqn *QualifiedName, trigger *whisk.Trigger, overwrite bool) { |
Member
dubee
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to familiarise myself with the cli repo and picked up this bug #313.
While working on it, I've realised some spots where unit tests would be welcome, so I added some based on Ginkgo, which I personally find pretty useful for TDD approach, general code coverage and documentation. What do you think guys, is this the right direction to go?
@rabbah @mdeuser @drcariel @houshengbo
The proposed change still has some nuances to be done properly: gradle deps for ginkgo and gomega, some duplication and probably a general clean up.