Skip to content

Conversation

@dubee
Copy link
Member

@dubee dubee commented Jan 31, 2019

Save Ballerina binaries with the proper extension.

Closes #403

@dubee dubee requested a review from rabbah January 31, 2019 17:54
@dubee dubee added the review label Jan 31, 2019
@rabbah
Copy link
Member

rabbah commented Feb 1, 2019

ok that was easy --- do you mind adding a go unit test https://github.com/apache/incubator-openwhisk-cli/blob/master/commands/action_test.go if it doesn't end up requiring a lot of refactoring?

@csantanapr
Copy link
Member

FTW ! Go unit tests

@rabbah rabbah merged commit 77c556d into apache:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants