Skip to content

Prepare 3.21.9 release#283

Merged
selfxp merged 4 commits into
masterfrom
prep-3.21.9-release
May 14, 2026
Merged

Prepare 3.21.9 release#283
selfxp merged 4 commits into
masterfrom
prep-3.21.9-release

Conversation

@selfxp
Copy link
Copy Markdown
Contributor

@selfxp selfxp commented May 12, 2026

Prepare openwhisk-client-js 3.21.9 release

  • Update NOTICE year
  • Bump version in package.json/package-lock.json
  • Fix CI

@selfxp selfxp requested review from dgrove-oss, rabbah and style95 May 12, 2026 00:51
Copy link
Copy Markdown
Member

@style95 style95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@style95
Copy link
Copy Markdown
Member

style95 commented May 12, 2026

Oddly, no CI is running.

@style95 style95 closed this May 12, 2026
@style95 style95 reopened this May 12, 2026
@style95
Copy link
Copy Markdown
Member

style95 commented May 12, 2026

It has been disabled because of inactivity. Reenable it.

@selfxp
Copy link
Copy Markdown
Contributor Author

selfxp commented May 13, 2026

Integration tests are failing, not because of this PR, but because OW doesn't correctly start. Is it still ok to merge @style95?

@style95
Copy link
Copy Markdown
Member

style95 commented May 13, 2026

I will defer to other reviewers.
I generally fix the issue from OW first and make it pass the CI to make sure.

Comment thread .github/workflows/ci.yaml Outdated
pip install 'jinja2<3.1' ansible==2.8.18
pip install pydocumentdb
pip install humanize requests
pip install humanize 'requests<2.32' 'urllib3<2' 'docker>=6,<7'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work if we update it to docker>=7.1.0?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i upgraded OW to the latest version 2.0, fixed ansible config, and now all tests, including the integration tests are passing. ok to merge? cc: @style95

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

Copy link
Copy Markdown
Member

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread .github/workflows/ci.yaml
working-directory: core/ansible
env:
ANSIBLE_CMD: "ansible-playbook -i environments/local -e docker_image_prefix=openwhisk -e docker_image_tag=nightly"
ANSIBLE_EXTRA_VARS: '{"scheduler_enable":false,"jmxremote_enabled":"","controller_loadbalancer_spi":"org.apache.openwhisk.core.loadBalancer.ShardingContainerPoolBalancer","invokerReactive_spi":"org.apache.openwhisk.core.invoker.InvokerReactive","invokerServer_spi":"org.apache.openwhisk.core.invoker.DefaultInvokerServer"}'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason that you used the ShardingPoolBalancer that is deprecated?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In OpenWhisk 2.0.0, the docs say the old shared state model was deprecated/removed, while sharding remains available.
Had to use it here because the default FPCPoolBalancer path expects scheduler/etcd configuration, which is what was breaking this CI. ShardingContainerPoolBalancer keeps this legacy Docker-based integration test working without enabling the scheduler path.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sharing that. I have no objection to merging this.
I was just wondering what the error was when the scheduler was breaking CI.

@selfxp selfxp merged commit 56d529d into master May 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants