Tightens logic and reports more meanigful error message when attempting to initialize more than once. #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabbah
force-pushed
the
init-once
branch
4 times, most recently
from
ee1a31d to
0e0856e
Compare
24 tasks
rabbah
changed the title
rabbah
changed the title
…tion is attempted more than once. Also: - Moved state setting out of doInit so that all state setting is localized to the route handlers. - Moved console.error messages around so that they appear before the sentinel on init and run errors.
dgrove-oss
approved these changes
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check in the init-handler to report an error if initialization is attempted more than once.
Also:
doInitso that all state setting is localized to the route handlers.console.errormessages around so that they appear before the sentinel on init and run errors.@tysonnorris having thought about this in the context of #41, I think we can achieve both mode by guarding the check in the run handler but leaving
stateotherwise in place.Closes #70.