Skip to content

Updated references around Node.js runtimes#443

Merged
mrutkows merged 3 commits into
apache:masterfrom
rraavi:nodejs-runtime-references
Sep 3, 2020
Merged

Updated references around Node.js runtimes#443
mrutkows merged 3 commits into
apache:masterfrom
rraavi:nodejs-runtime-references

Conversation

@rraavi
Copy link
Copy Markdown

@rraavi rraavi commented Sep 3, 2020

@rraavi rraavi marked this pull request as draft September 3, 2020 14:27
@rraavi rraavi marked this pull request as ready for review September 3, 2020 14:28
Copy link
Copy Markdown
Member

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We missed this when we updated the downloads page for the last openwhisk-runtime-nodejs release.

Comment thread _layouts/documentation.html Outdated
Copy link
Copy Markdown
Contributor

@mrutkows mrutkows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for updating our links and NodeJS version dependencies. If you can adopt Dave's sugg., then we can merge.

Raghuveer Raavi and others added 2 commits September 3, 2020 14:23
Co-authored-by: David Grove <dgrove-oss@users.noreply.github.com>
@rraavi
Copy link
Copy Markdown
Author

rraavi commented Sep 3, 2020

Associated PR around runtimes documentation- apache/openwhisk-runtime-nodejs#178

Copy link
Copy Markdown
Contributor

@mrutkows mrutkows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going the extra mile and validating many more links and correcting/removing as able/needed. Likely, the events (events.md) should be removed as we do not have the bandwidth to track and the events have likely shrunk to a small number directly ref. OpenWhisk. I will open an issue...

@mrutkows mrutkows merged commit 2d566a4 into apache:master Sep 3, 2020
@rraavi rraavi deleted the nodejs-runtime-references branch September 3, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants