Allow for a docker pull bypass for docker actions where the prefix maches the invoker's docker prefix#3052
Merged
csantanapr merged 1 commit intoapache:masterfrom Dec 13, 2017
Merged
Conversation
rabbah
force-pushed
the
localimages
branch
2 times, most recently
from
c9d2811 to
7ef28cc
Compare
rabbah
commented
Dec 3, 2017
| */ | ||
| def readFromEnv(key: String): Option[String] = sys.env.get(asEnvVar(key)) | ||
|
|
||
| private def whiskPropertiesFile: File = { |
Member
Author
There was a problem hiding this comment.
this file is now only used for tests and tests should use WhiskProperties which already have to discover this file.
rabbah
force-pushed
the
localimages
branch
8 times, most recently
from
989915f to
e038f31
Compare
rabbah
commented
Dec 7, 2017
| whisk_logs_dir: /Users/Shared/wsklogs | ||
| docker_registry: "" | ||
| docker_dns: "" | ||
| bypass_pull_for_local_images: true |
Member
Author
There was a problem hiding this comment.
@csantanapr what do you think about making this true for the local envs?
rabbah
added
review
rabbah
force-pushed
the
localimages
branch
11 times, most recently
from
33290b8 to
6f4817a
Compare
Contributor
|
@rabbah I don't have a chance to test the PR, but IIUC:
I think that should work for the local dev/testing or demo use case. With this in place, feel free to close #2852. |
Member
Author
|
If you’re using the local or Mac environments then 1 is done for you automatically. |
This commit adds a deployment flag which allows a docker action to be treated as a native image. A native image may eschew a docker pull. It is defined as one that has a prefix matching the docker prefix for managed images. Also added some missing tids.
BillZong
pushed a commit
to BillZong/openwhisk
that referenced
this pull request
Nov 18, 2019
This commit adds a deployment flag which allows a docker action to be treated as a native image. A native image may eschew a docker pull. It is defined as one that has a prefix matching the docker prefix for managed images. Also added some missing tids.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposed patch to address the feature request in #2852.
The presence of an property
bypassPullForLocalImagesin the runtime manifest will toggle the feature on or off allowing a docker pull to be skipped if the docker action's image name has a prefix matches the local docker build prefix.See https://github.com/apache/incubator-openwhisk/pull/3052/files#diff-d895f19f56edd5b725a1696b7b9d8877R196 for an example.
@alexkli can you take a look?