Add test for empty initializer. Document other tests. #3844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabbah
added
testing
review
dgrove-oss
reviewed
Jul 5, 2018
Member
dgrove-oss
left a comment
dgrove-oss
left a comment
There was a problem hiding this comment.
other than the question about checkResultInLogs, LGTM
| * Runs tests for actions which receive an empty initializer (no source or exec). | ||
| * @param checkResultInLogs should be true iff the result of the action is expected to appear in stdout or stderr | ||
| */ | ||
| def testNoSourceOrExec(checkResultInLogs: Boolean = true) = { |
Member
There was a problem hiding this comment.
Seems like checkResultInLogs is not used....should it be removed?
Member
Author
There was a problem hiding this comment.
updated to remove the relevant code.
Codecov Report
@@ Coverage Diff @@
## master #3844 +/- ##
=======================================
Coverage 74.61% 74.61%
=======================================
Files 138 138
Lines 6461 6461
Branches 397 397
=======================================
Hits 4821 4821
Misses 1640 1640Continue to review full report at Codecov.
|
Merged
24 tasks
BillZong
pushed a commit
to BillZong/openwhisk
that referenced
this pull request
Nov 18, 2019
* Add test for empty initializer. Document other tests. * Allow for a dot or dash in the action name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shifts tests which are part of the system package (but slated for removal as part of #3737, #3840) to container unit tests which also checks that the runtimes provide a consistent handling of different capabilities and error scenarios.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: