Skip to content

Improve Robustness of WskRestBasicUsageTests#4423

Merged
sven-lange-last merged 1 commit intoapache:masterfrom
mhenke1:correct_sequence
Apr 3, 2019
Merged

Improve Robustness of WskRestBasicUsageTests#4423
sven-lange-last merged 1 commit intoapache:masterfrom
mhenke1:correct_sequence

Conversation

@mhenke1
Copy link
Copy Markdown
Contributor

@mhenke1 mhenke1 commented Apr 2, 2019

Description

This PR changes the result comparison of two testcases to comparing sets instead of JsArrays.
This is introduced by seeing unstable results in some environments.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@mhenke1 mhenke1 changed the title Compile Test - Do not merge Compile Test - Do not merge - WIP Apr 2, 2019
@markusthoemmes
Copy link
Copy Markdown
Contributor

FWIW, if the sequence of these seems to matter in tests, we should make them not matter (by converting to a Set first).

@mhenke1 mhenke1 closed this Apr 2, 2019
@mhenke1 mhenke1 reopened this Apr 2, 2019
@mhenke1 mhenke1 closed this Apr 2, 2019
@mhenke1 mhenke1 reopened this Apr 2, 2019
@mhenke1
Copy link
Copy Markdown
Contributor Author

mhenke1 commented Apr 2, 2019

@markusthoemmes I observed some weird parameter sequence related problems on my local system that should have concluded that the original Travis test should never have been successful. But it is of course better to prevent such problems instead of being hit by them at unforeseen times.

@mhenke1 mhenke1 closed this Apr 2, 2019
@mhenke1 mhenke1 reopened this Apr 2, 2019
@mhenke1 mhenke1 changed the title Compile Test - Do not merge - WIP Improve Robustness of WskRestBasicUsageTests Apr 3, 2019
Copy link
Copy Markdown
Member

@sven-lange-last sven-lange-last left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this more robust. You followed @markusthoemmes proposal to transform the array to a set to perform the comparison independent from the element order.

Changes look good to me. Merging.

@sven-lange-last sven-lange-last merged commit 3523d41 into apache:master Apr 3, 2019
@mhenke1 mhenke1 deleted the correct_sequence branch April 3, 2019 07:30
BillZong pushed a commit to BillZong/openwhisk that referenced this pull request Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants