Improve Robustness of WskRestBasicUsageTests#4423
Merged
sven-lange-last merged 1 commit intoapache:masterfrom Apr 3, 2019
mhenke1:correct_sequence
Merged
Improve Robustness of WskRestBasicUsageTests#4423sven-lange-last merged 1 commit intoapache:masterfrom mhenke1:correct_sequence
sven-lange-last merged 1 commit intoapache:masterfrom
mhenke1:correct_sequence
Conversation
Contributor
|
FWIW, if the sequence of these seems to matter in tests, we should make them not matter (by converting to a Set first). |
Contributor
Author
|
@markusthoemmes I observed some weird parameter sequence related problems on my local system that should have concluded that the original Travis test should never have been successful. But it is of course better to prevent such problems instead of being hit by them at unforeseen times. |
sven-lange-last
approved these changes
Apr 3, 2019
Member
sven-lange-last
left a comment
There was a problem hiding this comment.
Thanks for making this more robust. You followed @markusthoemmes proposal to transform the array to a set to perform the comparison independent from the element order.
Changes look good to me. Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the result comparison of two testcases to comparing sets instead of JsArrays.
This is introduced by seeing unstable results in some environments.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: