Use spray json like approach for config derivation with Pureconfig#4783
Closed
chetanmeh wants to merge 2 commits intoapache:masterfrom
Closed
Use spray json like approach for config derivation with Pureconfig#4783chetanmeh wants to merge 2 commits intoapache:masterfrom
chetanmeh wants to merge 2 commits intoapache:masterfrom
Conversation
Member
Author
|
Below are the scalac profiling stats via Key aspects
Current masterPost config switch |
Member
Author
|
This needs to be put on hold for some time as no consensus was reached on Pureconfig side on used approach. Need to try a new simple macro based approach which looks like would take some time |
Member
|
@chetanmeh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on work done as part of #4509 to figure out approaches to reduce compilation times. It uses a new proposed approach to switch to non Shapeless based config derivation similar to what we do with spary-json
Description
This PR is a work in progress till the new support in Pureconfig is completed. With new approach the compilation time for
common/scalamodule reduced from ~ 60 sec to ~40 sec on my laptopRelated issue and scope
My changes affect the following components
Types of changes
Checklist: