Change AcknowledegmentMessage interface#4898
Merged
style95 merged 3 commits intoapache:masterfrom Jun 3, 2020
KeonHee:feature/ack-msg-interface
Merged
Change AcknowledegmentMessage interface#4898style95 merged 3 commits intoapache:masterfrom KeonHee:feature/ack-msg-interface
style95 merged 3 commits intoapache:masterfrom
KeonHee:feature/ack-msg-interface
Conversation
Member
|
hi @KeonHee can you expand on the need for this change? What components are you adding that are not "invokers" but which are sending ack messages? |
Member
Author
|
hello @rabbah sorry for late reply Yes we have a component called "scheduler" between the controller and invoker. |
style95
reviewed
May 18, 2020
| activationsPerNamespace.get(entry.namespaceId).foreach(_.decrement()) | ||
|
|
||
| releaseInvoker(invoker, entry) | ||
| invoker.foreach(releaseInvoker(_, entry)) |
Member
There was a problem hiding this comment.
👍
If this is to use some methods of CommonLoadBalancer in the downstream, isn't there any other methods to be updated as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
instanceTypejson field addedInstanceIdAcknowledegmentMessageinterfaceAcknowledegmentMessagemay not always respond to the invokerRelated issue and scope
no related issue
My changes affect the following components
Types of changes
Checklist: