Skip to content

Reactive prewarm - use proper ttl when replacing a prewarm#4913

Merged
tysonnorris merged 2 commits intoapache:masterfrom
adobe-apiplatform:reactive-prewarm-ttl
Jun 4, 2020
Merged

Reactive prewarm - use proper ttl when replacing a prewarm#4913
tysonnorris merged 2 commits intoapache:masterfrom
adobe-apiplatform:reactive-prewarm-ttl

Conversation

@tysonnorris
Copy link
Copy Markdown
Contributor

Initial impl of reactive prewarm did not derive the ttl for a replacement prewarm (when a prewarm is used). This fixes that so new prewarms have the appropriate ttl.

Description

Also added a test to exercise this ttl workflow for prewarm replacement.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@tysonnorris tysonnorris requested review from mcdan, selfxp and style95 May 28, 2020 20:53
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 28, 2020

Codecov Report

Merging #4913 into master will decrease coverage by 6.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4913      +/-   ##
==========================================
- Coverage   83.51%   77.26%   -6.26%     
==========================================
  Files         201      201              
  Lines        9441     9439       -2     
  Branches      396      406      +10     
==========================================
- Hits         7885     7293     -592     
- Misses       1556     2146     +590     
Impacted Files Coverage Δ
...e/openwhisk/core/containerpool/ContainerPool.scala 97.86% <100.00%> (-0.02%) ⬇️
...core/database/cosmosdb/RxObservableImplicits.scala 0.00% <0.00%> (-100.00%) ⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala 0.00% <0.00%> (-100.00%) ⬇️
...e/database/cosmosdb/cache/ChangeFeedConsumer.scala 0.00% <0.00%> (-100.00%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0.00% <0.00%> (-96.23%) ⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala 0.00% <0.00%> (-93.90%) ⬇️
...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala 0.00% <0.00%> (-92.31%) ⬇️
...enwhisk/connector/kafka/KamonMetricsReporter.scala 0.00% <0.00%> (-83.34%) ⬇️
...e/database/cosmosdb/cache/KafkaEventProducer.scala 0.00% <0.00%> (-77.78%) ⬇️
...whisk/core/database/cosmosdb/CosmosDBSupport.scala 0.00% <0.00%> (-74.08%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1274fdf...a95352d. Read the comment docs.

@ningyougang
Copy link
Copy Markdown
Contributor

LGTM

Copy link
Copy Markdown
Member

@style95 style95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@style95
Copy link
Copy Markdown
Member

style95 commented Jun 1, 2020

@tysonnorris
Thank you for addressing this.

@tysonnorris tysonnorris merged commit 395149d into apache:master Jun 4, 2020
@tysonnorris tysonnorris deleted the reactive-prewarm-ttl branch June 4, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants