Reactive prewarm - use proper ttl when replacing a prewarm#4913
Merged
tysonnorris merged 2 commits intoapache:masterfrom Jun 4, 2020
Merged
Reactive prewarm - use proper ttl when replacing a prewarm#4913tysonnorris merged 2 commits intoapache:masterfrom
tysonnorris merged 2 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4913 +/- ##
==========================================
- Coverage 83.51% 77.26% -6.26%
==========================================
Files 201 201
Lines 9441 9439 -2
Branches 396 406 +10
==========================================
- Hits 7885 7293 -592
- Misses 1556 2146 +590
Continue to review full report at Codecov.
|
Contributor
|
LGTM |
Member
|
@tysonnorris |
jiangpengcheng
approved these changes
Jun 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial impl of reactive prewarm did not derive the ttl for a replacement prewarm (when a prewarm is used). This fixes that so new prewarms have the appropriate ttl.
Description
Also added a test to exercise this ttl workflow for prewarm replacement.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: