Fix error handling and partition config bugs in KafkaMessagingProvide…

[quintenp01]

…r.ensureTopic

Description

Fixes two bugs in KafkaMessagingProvider.ensureTopic:

1. Errors creating the topic were inadvertently swallowed before this change due to using Try.map instead of Try.flatMap. We observed this when the Scheduler did not abort after failing to create it's scheduler topic.
2. Using the topic partitions configuration does not work in it's current state. This is because the number of partitions for a new topic is provided as a separate parameter rather than part of the topic configuration. This change removes partitions from the topic configuration prior to creating the topic.

Related issue and scope

• I opened an issue to propose and discuss this change (#????)

My changes affect the following components

• API
• Controller
• Message Bus (e.g., Kafka)
• Loadbalancer
• Scheduler
• Invoker
• Intrinsic actions (e.g., sequences, conductors)
• Data stores (e.g., CouchDB)
• Tests
• Deployment
• CLI
• General tooling
• Documentation

Types of changes

• Bug fix (generally a non-breaking change which closes an issue).
• Enhancement or new feature (adds new functionality).
• Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

• I signed an Apache CLA.
• I reviewed the style guides and followed the recommendations (Travis CI will check :).
• I added tests to cover my changes.
• My changes require further changes to the documentation.
• I updated the documentation where necessary.

[bdoyle0182]

LGTM