Skip to content

ORC-FORMAT-6: Add CompressionKind.BROTLI#7

Merged
williamhyun merged 1 commit intoapache:mainfrom
dongjoon-hyun:ORC-FORMAT-6
Dec 8, 2023
Merged

ORC-FORMAT-6: Add CompressionKind.BROTLI#7
williamhyun merged 1 commit intoapache:mainfrom
dongjoon-hyun:ORC-FORMAT-6

Conversation

@dongjoon-hyun
Copy link
Member

What changes were proposed in this pull request?

This closes #6 by adding CompressionKind.BROTLI as a new compression type.

Why are the changes needed?

To support ORC-1463 at Apache ORC Format 1.0.0.

How was this patch tested?

Pass the CIs.

@dongjoon-hyun
Copy link
Member Author

cc @deshanxiao, @williamhyun , @wgtmac

Copy link
Member

@williamhyun williamhyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

I'll be merging this now.

@williamhyun williamhyun merged commit 9753755 into apache:main Dec 8, 2023
@dongjoon-hyun
Copy link
Member Author

Thank you so much, @williamhyun !

@deshanxiao
Copy link

+1 Thank you @dongjoon-hyun .

Sorry for my late response.

@dongjoon-hyun
Copy link
Member Author

Thank you, @deshanxiao . No problem. :)

dongjoon-hyun added a commit to apache/orc that referenced this pull request Dec 9, 2023
### What changes were proposed in this pull request?

This PR aims to use `orc-format` `1.0.0-beta`.

### Why are the changes needed?

`1.0.0-beta` has the following changes.
- apache/orc-format#5
- apache/orc-format#4
- apache/orc-format#7
- apache/orc-format#9

### How was this patch tested?

Pass the CIs.

Closes #1688 from dongjoon-hyun/ORC-1551.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
cxzl25 pushed a commit to cxzl25/orc that referenced this pull request Jan 11, 2024
### What changes were proposed in this pull request?

This PR aims to use `orc-format` `1.0.0-beta`.

### Why are the changes needed?

`1.0.0-beta` has the following changes.
- apache/orc-format#5
- apache/orc-format#4
- apache/orc-format#7
- apache/orc-format#9

### How was this patch tested?

Pass the CIs.

Closes apache#1688 from dongjoon-hyun/ORC-1551.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CompressionKind.BROTLI

3 participants