ORC-183: Add a method in Type to build type#115
Closed
wgtmac wants to merge 3 commits intoapache:masterfrom
Closed
ORC-183: Add a method in Type to build type#115wgtmac wants to merge 3 commits intoapache:masterfrom
wgtmac wants to merge 3 commits intoapache:masterfrom
Conversation
Added static Type* buildTypeFromString(const std::string& input)
omalley
requested changes
May 3, 2017
c++/include/orc/Type.hh
Outdated
| /** | ||
| * Build a Type object from string text representation. | ||
| */ | ||
| static Type* buildTypeFromString(const std::string& input); |
Contributor
There was a problem hiding this comment.
Let's make it a unique_ptr to make it clear that the caller owns the pointer.
c++/src/TypeImpl.cc
Outdated
| return std::unique_ptr<Type>(result); | ||
| } | ||
|
|
||
| Type * Type::buildTypeFromString(const std::string& input) { |
Contributor
There was a problem hiding this comment.
This should probably be factored in to smaller functions. Take a look at the equivalent java https://github.com/apache/orc/blob/master/java/core/src/java/org/apache/orc/TypeDescription.java#L396 and you'll see parseName, parseCategory, parseInteger, etc.
Member
Author
There was a problem hiding this comment.
Make sense. I will do the refactoring soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added static Type* buildTypeFromString(const std::string& input)