ORC-1270: Move opencsv dependency to the tools module#1251
Closed
williamhyun wants to merge 1 commit intoapache:mainfrom
Closed
ORC-1270: Move opencsv dependency to the tools module#1251williamhyun wants to merge 1 commit intoapache:mainfrom
williamhyun wants to merge 1 commit intoapache:mainfrom
Conversation
Member
Author
|
cc: @dongjoon-hyun |
dongjoon-hyun
approved these changes
Sep 13, 2022
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @williamhyun .
Merged to main/1.8.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 13, 2022
### What changes were proposed in this pull request? This PR aims to move the `opencsv` dependency to the tools module. ### Why are the changes needed? `opencsv` is used only by the tools module. ### How was this patch tested? Pass the CIs. Closes #1251 from williamhyun/moveopencsv. Authored-by: William Hyun <william@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 03149db) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
cxzl25
pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
### What changes were proposed in this pull request? This PR aims to move the `opencsv` dependency to the tools module. ### Why are the changes needed? `opencsv` is used only by the tools module. ### How was this patch tested? Pass the CIs. Closes apache#1251 from williamhyun/moveopencsv. Authored-by: William Hyun <william@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to move the
opencsvdependency to the tools module.Why are the changes needed?
opencsvis used only by the tools module.How was this patch tested?
Pass the CIs.