ORC-1291: Fix NPE in TypeDescription.hashCode() for primitive types#1283
Closed
dongjoon-hyun wants to merge 1 commit intoapache:mainfrom
Closed
ORC-1291: Fix NPE in TypeDescription.hashCode() for primitive types#1283dongjoon-hyun wants to merge 1 commit intoapache:mainfrom
TypeDescription.hashCode() for primitive types#1283dongjoon-hyun wants to merge 1 commit intoapache:mainfrom
Conversation
dongjoon-hyun
changed the title
TypeDescription.hashCode() for primitive types
Member
Author
|
cc @williamhyun and @wgtmac |
wgtmac
approved these changes
Oct 19, 2022
Member
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
+1. Thanks @dongjoon-hyun for addressing this.
williamhyun
pushed a commit
that referenced
this pull request
Oct 19, 2022
### What changes were proposed in this pull request? This PR aims to fix NPE in `TypeDescription.hashCode()` for primitive types. ### Why are the changes needed? To fix a regression at 1.8.0. ### How was this patch tested? Pass the CI with the newly added test case. Closes #1283 from dongjoon-hyun/ORC-1291. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: William Hyun <william@apache.org> (cherry picked from commit d1971ea) Signed-off-by: William Hyun <william@apache.org>
Member
Author
|
Thank you, @wgtmac and @williamhyun ! |
cxzl25
pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
### What changes were proposed in this pull request? This PR aims to fix NPE in `TypeDescription.hashCode()` for primitive types. ### Why are the changes needed? To fix a regression at 1.8.0. ### How was this patch tested? Pass the CI with the newly added test case. Closes apache#1283 from dongjoon-hyun/ORC-1291. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: William Hyun <william@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix NPE in
TypeDescription.hashCode()for primitive types.Why are the changes needed?
To fix a regression at 1.8.0.
How was this patch tested?
Pass the CI with the newly added test case.