ORC-312: [C++] Fix buffer overflow in corrupt StringDictionaryColumn#224
Closed
stiga-huang wants to merge 3 commits into
Closed
ORC-312: [C++] Fix buffer overflow in corrupt StringDictionaryColumn#224stiga-huang wants to merge 3 commits into
stiga-huang wants to merge 3 commits into
Conversation
stiga-huang
changed the title
In the constructor of StringDictionaryColumnReader, if there're
negative values in the decoded lengthArray, the calculated blobSize
may be negative. It will be transformed to a huge unsigned integer.
Finally, we crash on DataBuffer::resize
dictionaryBlob.resize(static_cast<uint64_t>(blobSize))
This patch checks for negative length and throws ParseError in time.
majetideepak
approved these changes
Mar 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crash is due to the buffer overflow in orc::readFully which only used in StringDictionaryColumnReader currently. The decoded length may larger than we expected if the file is corrupt.
This patch also adds checks for the range of entry indices in StringDictionaryColumnReader::next.