Skip to content

Conversation

@WillAyd
Copy link
Contributor

@WillAyd WillAyd commented Jun 23, 2025

What changes were proposed in this pull request?

This removes setting the Meson configuration to remove the buildtype of release by default.

Why are the changes needed?

While coming from CMake it may seem like a good idea to build release builds by default, the setting is either ignored or problematic when orc is used as a subproject in other projects, especially on Windows where a main project building a library with debug symbols may fail if a subproject tries to force release symbols.

How was this patch tested?

Compiled locally

Was this patch authored or co-authored using generative AI tooling?

No

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I'm a little reluctant to downgrade the default behavior here.

Does Mesos has no corresponding feature like RELWITHDEBINFO of CMake?

@WillAyd
Copy link
Contributor Author

WillAyd commented Jun 24, 2025

Yes it does - that would be the debugoptimized build type

https://mesonbuild.com/Builtin-options.html#core-options

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Jun 24, 2025

Could you provide some reference what is the standard (or recommended way) in Meson? debug or debugoptimized ?

In addition, I'm wondering if Mesos eco-system is enforcing debug for all libraries or not? To me, it's a little weird that release is not enabled by default in source release.

@WillAyd
Copy link
Contributor Author

WillAyd commented Jun 24, 2025

By default meson will produce debug libraries. If you want something else, it is encouraged for the user to specify that from the command line when configuring their project, rather than having a (sub-)project enforce a particular build type. There is some upstream discussion about this in mesonbuild/wrapdb#2208

@dongjoon-hyun
Copy link
Member

The upstream discussion looks like a new one (5 days ago) instead of the stabilized one. Let's have more time to think about this since we still have enough time for Apache ORC 2.2 release.

@dongjoon-hyun dongjoon-hyun changed the title ORC-1937: Remove generating release build in Meson config by default ORC-1937: Use the default buildtype in Meson config Jun 25, 2025
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. I slightly revisited the PR title according to the AS-IS status.

@dongjoon-hyun dongjoon-hyun added this to the 2.2.0 milestone Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants