ORC-248. PhysicalFsWriter sometimes passes negative padding down to shims#259
Merged
asfgit merged 1 commit intoapache:masterfrom May 1, 2018
Merged
ORC-248. PhysicalFsWriter sometimes passes negative padding down to shims#259asfgit merged 1 commit intoapache:masterfrom
asfgit merged 1 commit intoapache:masterfrom
Conversation
omalley
force-pushed
the
orc-248
branch
2 times, most recently
from
9423c71 to
09d71b5
Compare
omalley
added a commit
to omalley/orc
that referenced
this pull request
Apr 30, 2018
requested padding to the shims. Fixes apache#259 Signed-off-by: Owen O'Malley <omalley@apache.org>
omalley
added a commit
to omalley/orc
that referenced
this pull request
May 1, 2018
requested padding to the shims. Fixes apache#259 Signed-off-by: Owen O'Malley <omalley@apache.org>
t3rmin4t0r
approved these changes
May 1, 2018
| IS_SCHEMA_EVOLUTION_CASE_SENSITIVE("orc.schema.evolution.case.sensitive", "orc.schema.evolution.case.sensitive", true, | ||
| "A boolean flag to determine if the comparision of field names in schema evolution is case sensitive .\n") | ||
| "A boolean flag to determine if the comparision of field names in schema evolution is case sensitive .\n"), | ||
| WRITE_SHORTENED_BLOCKS("orc.write.shortened.blocks", null, false, |
Contributor
There was a problem hiding this comment.
Might as well call it what it is "orc.write.variable.length.blocks"
omalley
added a commit
to omalley/orc
that referenced
this pull request
May 1, 2018
requested padding to the shims. Fixes apache#259 Signed-off-by: Owen O'Malley <omalley@apache.org>
requested padding to the shims. Fixes apache#259 Signed-off-by: Owen O'Malley <omalley@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PhysicalFsWriter sometimes pass down negative sizes for padding, which leads to exceptions.
My fix: